Skip to content

Task 2396: Migrate Large Static Images to S3 Bucket#2415

Open
jlchilders11 wants to merge 6 commits into
developfrom
jc/migrate-existing-large-images
Open

Task 2396: Migrate Large Static Images to S3 Bucket#2415
jlchilders11 wants to merge 6 commits into
developfrom
jc/migrate-existing-large-images

Conversation

@jlchilders11
Copy link
Copy Markdown
Collaborator

@jlchilders11 jlchilders11 commented May 8, 2026 •
edited
Loading

Issue: #2396

Summary & Context

Moves all V3 images to s3 bucket, and converts existing static calls to use large_static, which pulls from either the bucket or local synced content.

Dev Notes & QA

For testing purposes, devs should remember to run just down_sycn_images to actually sync the s3 buckets to local.

For Testing purposes, the following pages are affected by this change:

‼️ Risks & Considerations ‼️

Please list any potential risks or areas that need extra attention during review/testing

Self-review Checklist

  • Tag at least one team member from each team to review this PR
  • Link this PR to the related GitHub Project ticket

@jlchilders11 jlchilders11 requested review from julhoang and ycanales May 8, 2026 20:41
@jlchilders11 jlchilders11 linked an issue May 8, 2026 that may be closed by this pull request
Task: Migrate Existing Large Images to S3 #2396
Open
@herzog0 herzog0 self-requested a review May 11, 2026 15:13
herzog0
herzog0 requested changes May 11, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@herzog0 herzog0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far! However, the learn page is still referencing old image paths. While #2414 doesn't get merged, I simply removed the wrong references to _post_cards_v3.html in the learn_page.html template to render it partially, and the images are indeed broken there. I don't think altering them in this same PR should have any major conflicts with your other branch.

Image

julhoang
julhoang reviewed May 11, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@julhoang julhoang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jlchilders11 , thanks for tackling this task!

1/ Question: I've noticed that we're loading small images (e.g. the Badge icons) to S3 now too. My understanding previously was that we only want to use S3 for large images (> 1 MB). Just to confirm, will this be our new strategy going forward?

2/ Suggestion: I think there are a few unused images that we can delete from S3:

  • thelogin-page folder (we already have auth-page folder)
  • demo_page/Badge.svg
  • home-page/home-page-placeholder.png
  • Both images under /learn are currently not used, I think the Learn page is using the all the images under /examples? Maybe we should consider replacing /learn with /examples if possible 🤔

3/ Nit suggestion: While we're cleaning up the images.. if we can rename the capitalized images (e.g Cheetah_Mobile.png) to lowercase that would be really nice

Comment thread core/views.py
@jlchilders11
Copy link
Copy Markdown
Collaborator Author

jlchilders11 commented May 11, 2026

Hi @jlchilders11 , thanks for tackling this task!

1/ Question: I've noticed that we're loading small images (e.g. the Badge icons) to S3 now too. My understanding previously was that we only want to use S3 for large images (> 1 MB). Just to confirm, will this be our new strategy going forward?

2/ Suggestion: I think there are a few unused images that we can delete from S3:

* the`login-page` folder (we already have `auth-page` folder)

* `demo_page/Badge.svg`

* `home-page/home-page-placeholder.png`

* Both images under `/learn` are currently not used, I think the Learn page is using the all the images under `/examples`? Maybe we should consider replacing `/learn` with `/examples` if possible 🤔

3/ Nit suggestion: While we're cleaning up the images.. if we can rename the capitalized images (e.g Cheetah_Mobile.png) to lowercase that would be really nice

@julhoang

  1. While that was the initial suggestion, I believe that all images for v3 should be moved to S3, now that we have the infrastructure to handle it. I don't believe there is any downside to having the images there, and it prevents the menal overhead of devs having to manually figure out where the image should go.

  2. Good call. I removed the existing learn and learn-page folders, and renamed examples to learn-page since that is more accurate. While I was at it, I renamed demo_page to demo-page to better fit our paradigm

  3. Also a good clean up, made that change, and also lower cased Avatar.png and Calendar.png while I was at it.

@jlchilders11 jlchilders11 requested review from herzog0 and julhoang May 11, 2026 20:46
ycanales
ycanales reviewed May 12, 2026
View reviewed changes
Comment thread core/views.py Outdated
herzog0
herzog0 requested changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@herzog0 herzog0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have this one ask, aside from Cristian's one above

Comment thread templates/v3/learn_page.html Outdated
@jlchilders11 jlchilders11 requested a review from herzog0 May 12, 2026 17:41
julhoang
julhoang approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@julhoang julhoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the updates @jlchilders11 🧹 ✨!

herzog0
herzog0 approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@herzog0 herzog0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fixes!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ycanales ycanales ycanales approved these changes

@herzog0 herzog0 herzog0 approved these changes

@julhoang julhoang julhoang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Task: Migrate Existing Large Images to S3

4 participants

@jlchilders11 @ycanales @herzog0 @julhoang